[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-21 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 187751. bader added a comment. Applied comments from @ABataev. - Split changes into two patches. This part contains front-end option enabling device specific macro. Changes adding driver option will be sent in a separate patch. - Added LIT test Repository:

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-14 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Herald added a subscriber: jdoerfert. In D57768#1389012 , @rjmccall wrote: > In D57768#1386862 , @Anastasia wrote: > > > - SYCL seem to require adding tight dependencies from the standard

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D57768#1392975 , @bader wrote: > In D57768#1386941 , @ABataev wrote: > > > In D57768#1386933 , @bader wrote: > > > > > In D57768#1386924

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-11 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D57768#1386941 , @ABataev wrote: > In D57768#1386933 , @bader wrote: > > > In D57768#1386924 , @ABataev wrote: > > > > > This definitely requires a

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D57768#1386862 , @Anastasia wrote: > - SYCL seem to require adding tight dependencies from the standard libraries > into the compiler because many language features are hidden behind library > classes. This is not common for

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D57768#1386933 , @bader wrote: > In D57768#1386924 , @ABataev wrote: > > > This definitely requires a test. > > > @ABataev, I tried to find some tests on similar `-fcuda-is-device` and

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-06 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D57768#1386924 , @ABataev wrote: > This definitely requires a test. @ABataev, I tried to find some tests on similar `-fcuda-is-device` and `-fopenmp-is-device` options, but I wasn't able to find a dedicated test. Could you

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. This definitely requires a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added subscribers: rjmccall, rsmith. Anastasia added a comment. In D57768#1386791 , @bader wrote: > In D57768#1386754 , @Naghasan wrote: > > > LGTM > > > > Side note: might be good to also involve

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-06 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D57768#1386754 , @Naghasan wrote: > LGTM > > Side note: might be good to also involve @Anastasia, as some of the future > patches will overlap with OpenCL. Sure. I'll add @Anastasia as a reviewer to the relevant patches.

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-06 Thread Victor Lomuller via Phabricator via cfe-commits
Naghasan accepted this revision. Naghasan added a subscriber: Anastasia. Naghasan added a comment. LGTM Side note: might be good to also involve @Anastasia, as some of the future patches will overlap with OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-05 Thread Ronan Keryell via Phabricator via cfe-commits
keryell accepted this revision. keryell added a comment. This revision is now accepted and ready to land. That looks good. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

2019-02-05 Thread Alexey Bader via Phabricator via cfe-commits
bader created this revision. bader added reviewers: keryell, Naghasan. Herald added subscribers: cfe-commits, ebevhan. Herald added a project: clang. -fsycl-is-device enables compilation of the device part of SYCL source file. Patch by Mariya Podchishchaeva Repository: rG LLVM Github