[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353554: [clang-tidy] Don't use assignment for value-initialized enums (authored by malcolm.parsons, committed by ). Changed prior to commit: https://reviews.llvm.org/D57852?vs=185649&id=186014#toc Re

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57852/new/ https://reviews.llvm.org/D57852 _

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

malcolm.parsons marked an inline comment as done. malcolm.parsons added a comment. In D57852#1388526 , @JonasToth wrote: > How are the semantics for `enum class` in this case? No enumerators are present in the initialisation or the fixit, so there is no

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

JonasToth added a comment. How are the semantics for `enum class` in this case? Comment at: clang-tools-extra/test/clang-tidy/modernize-use-default-member-init-assignment.cpp:172 + // CHECK-FIXES: PositiveValueEnum() {} + Enum e; + // CHECK-MESSAGES: :[[@LINE-1]]:8: warnin

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The modernize-use-default-member-init check crashes when trying to create an assignment value for a value-initi