[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

2019-02-07 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353413: [clangd] Use Dex for dynamic index by default. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D57878?vs=185762=185763#toc Repository: rCTE Clang

[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

2019-02-07 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 185762. ioeric added a comment. - Keep the option for now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57878/new/ https://reviews.llvm.org/D57878 Files: clangd/tool/ClangdMain.cpp Index:

[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

2019-02-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Just flipping the flag seems fine too) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57878/new/ https://reviews.llvm.org/D57878

[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

2019-02-07 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Memory usage for a sample TU: Without Dex: 17.9M WithDex: 24.4M The memory increase is considerable but seems tolerable.