baloghadamsoftware added a comment.
Herald added subscribers: ASDenysPetrov, martong, steakhal.
I think you can create a unit test for this: create a pre-call checker that
checks for the assignment operator and asserts that we are not in top level.
Create a test code with a simple class without
Szelethus requested changes to this revision.
Szelethus added a comment.
This revision now requires changes to proceed.
Herald added subscribers: Charusso, jdoerfert, whisperity.
Yup, I agree.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57890/new/
https://revie
NoQ added a comment.
Sounds reasonable, but it also sounds like something that should be
reproducible on the upstream clang. Do you have a code snippet that causes the
problematic AST to appear? Even if we don't have the false positive up here in
upstream, Is it something we can test via `-anal
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
Just wanted to make sure I get it right. You did not add a test since it is
only reproducible with an internal (non-upstreamed) checker. Since the change
is trivial, I think it is o
bruntib created this revision.
bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun,
baloghadamsoftware.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, rnkovacs, szepet.
Herald added a project: clang.
For self assignment checker it was nece
