Re: [PATCH] D57898: [RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators

2019-02-08 Thread Alexander Potapenko via cfe-commits
Still unsure about the heuristic here. I believe that for auto-initialization we want to be quite aggressive with these splits (unlike for regular constant stores). Perhaps we should do the split in the case all bytes are pattern bytes? (This is probably another use case for `forInit`) On Fri,

[PATCH] D57898: [RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators

2019-02-08 Thread Alexander Potapenko via Phabricator via cfe-commits
glider marked 2 inline comments as not done. glider added a comment. Sorry, didn't mean to mark these done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list

[PATCH] D57898: [RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators

2019-02-08 Thread Alexander Potapenko via Phabricator via cfe-commits
glider marked 2 inline comments as done. glider added inline comments. Comment at: tools/clang/lib/CodeGen/CGDecl.cpp:1143 +const llvm::StructLayout *Layout = +CGM.getDataLayout().getStructLayout(cast(Ty)); +for (unsigned i = 0; i != constant->getNumOperands();