[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus added a comment. I committed but changed the moves to copies. Singel `CheckerRegisrty::CmdLineOption` is only filled with `StringRef`s, it shouldn't really matter. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:314 insertOptionToCollection(StringRef Fu

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rL361006: [analyzer] Insert checker options into AnalyzerOption::ConfigTable (au

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:314 insertOptionToCollection(StringRef FullName, T &Collection, - const CheckerRegistry::CmdLineOption &&Option) { + const CheckerRegistry::CmdL

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

whisperity added a comment. I think this is good. Patch still marked as //Needs review// for some reason. 😦 Can we look up this `blocking review` thing? Perhaps this could be marked ready to roll once the dependency patch is ironed out. Comment at: lib/StaticAnalyzer/Frontend

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

dcoughlin added a comment. This looks good to me. It is great to see this tested! Did you consider separating the checker options from the non-checker options in the config dumper output? That would probably be easier to read. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ h

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 190991. Szelethus added a comment. Add a test case for checker plugins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 Files: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp lib/StaticAnalyzer/Frontend/Ch

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 190979. Szelethus added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 Files: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp test/Anal

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 190628. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 Files: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h lib/StaticAnalyzer/Core/AnalyzerOptions.cpp lib/StaticAnalyzer/Frontend/CheckerReg

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:332 + AnOpts.Config.insert({(Twine() + CheckerFullName + ":" + OptionName).str(), +DefaultValStr}); } `Twine(CheckerFullName) + ":" + O

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 190021. Szelethus added a comment. Removed every piece of code not directly related to inserting checker option to the config table, moving it to a new patch. This essentially restores the revision to it's earliest state, except that it's even simpler: no

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus planned changes to this revision. Szelethus added a comment. Uhh, we still need to restore the default value -- I might end up splitting this patch a little further. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 __

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 189107. Szelethus added a comment. Herald added a reviewer: teemperor. Herald added a subscriber: Charusso. This revision now requires review to proceed. Remove the default value parameters from `getChecker*Option`, as they are no longer necessary. Note the

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus added a comment. Herald added a subscriber: jdoerfert. Hmm, supplying the default value for `AnalyzerOptions::getChecker*Option` is not only redundant with this patch, but also extremely bug-prone. I should remove them too in the same breath. Repository: rC Clang CHANGES SINCE LAS

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 ___ cfe-commi

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:183 SearchInParents) - .getAsInteger(10, Ret); + .getAsInteger(0

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a project: clang. The more entries we hav