[PATCH] D57935: [Sema] Make string literal init an rvalue.

2019-02-08 Thread Eli Friedman via Phabricator via cfe-commits
efriedma closed this revision. efriedma added a comment. https://reviews.llvm.org/rC353569 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57935/new/ https://reviews.llvm.org/D57935 ___ cfe-commits mailing list cfe-com

[PATCH] D57935: [Sema] Make string literal init an rvalue.

2019-02-08 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this is a much cleaner model than having two different `APValue` representations for arrays. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57935/new/

[PATCH] D57935: [Sema] Make string literal init an rvalue.

2019-02-07 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added a reviewer: rsmith. Herald added a project: clang. This allows substantially simplifying the expression evaluation code, because we don't have to special-case lvalues which are actually string literal initialization. This currently throws away an o