[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356134: [clangd] Using symbol name to map includes for STL symbols. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D58345?vs=190598=190600#toc Repository:

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190598. hokein marked an inline comment as done. hokein added a comment. One more comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files:

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/CanonicalIncludes.cpp:111 - {"std::addressof", ""}, - // Map symbols in to their preferred includes. {"std::basic_filebuf",

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:123 static const std::vector> SystemHeaderMap = { ioeric wrote: > ioeric wrote: > > hokein wrote: > > > sammccall wrote: > > > > hokein wrote: > > > > > ioeric wrote: > > >

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190592. hokein marked 4 inline comments as done. hokein added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files:

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added inline comments. Comment at: clangd/include-mapping/gen_std.py:46 +// +// Generated from cppreference offline HTML book v%s. +//===--===// I'd suggest dropping `v` prefix as it

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# ioeric wrote: > hokein wrote: > > ioeric wrote: > > > I'd avoid abbreviation in the

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190406. hokein marked 3 inline comments as done. hokein added a comment. Rename the tool. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files:

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# hokein wrote: > ioeric wrote: > > I'd avoid abbreviation in the file name and the new

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190275. hokein marked 13 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files:

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# ioeric wrote: > I'd avoid abbreviation in the file name and the new directory name.

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# I'd avoid abbreviation in the file name and the new directory name. `StdGen` sounds

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added a comment. add @ioeric as a reviewer, since @sammccall is OOO. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 ___ cfe-commits mailing list

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190218. hokein marked 4 inline comments as done. hokein added a comment. Herald added a reviewer: serge-sans-paille. Address review comments, rewrite the tool with python. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

klimek added a comment. In D58345#1406892 , @sammccall wrote: > Sorry to be a pain here, but I'm not sure introducing Javascript is a good > idea unless there's a strong reason for it. > All LLVM developers have python installed, many are comfortable

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

sammccall added a subscriber: klimek. sammccall added a comment. Sorry to be a pain here, but I'm not sure introducing Javascript is a good idea unless there's a strong reason for it. All LLVM developers have python installed, many are comfortable with the language - it seems less likely to be

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added a comment. In D58345#1401907 , @sammccall wrote: > In D58345#1401213 , @hokein wrote: > > > In D58345#1401040 , @ioeric wrote: > > > > > Looks great! Thanks for

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 187835. hokein marked 6 inline comments as done. hokein added a comment. - address comments - narrow the scope of this patch -- only emit unique symbols - add the generator tool Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:47 + // headers (e.g. std::move from and ), using + // qualified name can not disambiguate headers. Instead we should return all + // headers and do the

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

sammccall added a comment. In D58345#1401213 , @hokein wrote: > In D58345#1401040 , @ioeric wrote: > > > Looks great! Thanks for doing this. > > > > Could you also check in the tool that is used to generate the

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

sammccall added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:123 static const std::vector> SystemHeaderMap = { hokein wrote: > ioeric wrote: > > Can we remove the suffix header mapping now? Is it for the `std::chrono::` > >

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein marked an inline comment as done. hokein added a comment. In D58345#1401040 , @ioeric wrote: > Looks great! Thanks for doing this. > > Could you also check in the tool that is used to generate the mapping? We > need a way to update the mapping

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added a comment. Looks great! Thanks for doing this. Could you also check in the tool that is used to generate the mapping? We need a way to update the mapping when cppreference is updated. Comment at: clangd/index/CanonicalIncludes.cpp:123 static const

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 187225. hokein added a comment. Fix style. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files: clangd/StdSymbolMap.imp clangd/index/CanonicalIncludes.cpp

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a reviewer: jfb. Herald added subscribers: jdoerfert, jfb, kadircet, arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Using suffix path mapping relies on the STL