[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-27 Thread Jan Korous via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC355035: [clang][index-while-building] FileIndexRecord (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D58478?vs=187863&id=188614#toc Repository: rC Clang CHAN

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-27 Thread Nathan Hawes via Phabricator via cfe-commits
nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing l

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-27 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. ping -c 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-21 Thread Jan Korous via Phabricator via cfe-commits
jkorous marked 3 inline comments as done. jkorous added a comment. Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-21 Thread Jan Korous via Phabricator via cfe-commits
jkorous updated this revision to Diff 187863. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 Files: clang/include/clang/Index/DeclOccurrence.h clang/lib/Index/CMakeLists.txt clang/lib/Index/FileIndexRecord.cpp clang/lib/Index/FileIndexRec

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-21 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang/include/clang/Index/DeclOccurrence.h:1 +//===--- DeclOccurrence.h - An occurrence of a decl within a file - C++ -*-===// +// Tag should contain *- C++ -*, so you could remove dashes at beginning and equal

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-21 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. Thanks Eugene. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-21 Thread Jan Korous via Phabricator via cfe-commits
jkorous updated this revision to Diff 187848. jkorous marked 5 inline comments as done. jkorous added a comment. - license - remove auto CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 Files: clang/include/clang/Index/DeclOccurrence.h clang/

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-20 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang/include/clang/Index/DeclOccurrence.h:1 +//===--- DeclOccurrence.h - An occurrence of a decl within a file -===// +// Missing C++ tag. See other headers as example. Comment at: cla

[PATCH] D58478: [index-while-building] FileIndexRecord

2019-02-20 Thread Jan Korous via Phabricator via cfe-commits
jkorous created this revision. jkorous added reviewers: dexonsmith, nathawes, akyrtzi, arphaman, ioeric, malaperle. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. Basic data structures for index Tests are missing from this patch - will be covered properl