joerg marked an inline comment as done.
joerg added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:860
+ if (!ImmSet.empty())
+return ImmSet.count(Value.getZExtValue()) != 0;
+ return !ImmRange.isConstrained || (Value.sge(ImmRange.Min) &&
Value.s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL354937: Fix inline assembler constraint validation (authored
by joerg, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
efriedma added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:860
+ if (!ImmSet.empty())
+return ImmSet.count(Value.getZExtValue()) != 0;
+ return !ImmRange.isConstrained || (Value.sge(ImmRange.Min) &&
Value.sle(ImmRange.Max));
I
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Nice find!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58649/new/
https://reviews.llvm.org/D58649
___
cfe-commits mailing list
cfe
joerg created this revision.
joerg added a reviewer: compnerd.
Herald added a subscriber: eraman.
The current constraint logic is both too lax and too strict. It fails for input
outside the [INT_MIN..INT_MAX] range, but it also implicitly accepts 0 as value
when it should not. Adjust logic to ha
