[PATCH] D58710: Added more detailed documentation for clangd

kadircet added inline comments. Comment at: clang-tools-extra/trunk/docs/clangd/Installation.rst:325 + + $ ln -s ~/myproject/compile_commands.json ~/myproject-build/ + thakis wrote: > Isn't the order of the arguments the wrong way round here? yeah that seems to

[PATCH] D58710: Added more detailed documentation for clangd

thakis added inline comments. Comment at: clang-tools-extra/trunk/docs/clangd/Installation.rst:325 + + $ ln -s ~/myproject/compile_commands.json ~/myproject-build/ + Isn't the order of the arguments the wrong way round here? Repository: rL LLVM CHANGES

[PATCH] D58710: Added more detailed documentation for clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL354992: Added more detailed documentation for clangd (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188536. gribozavr added a comment. Removed mentions of clangd v9. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188535. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files: clang-tools-extra/docs/_static/clang-tools-extra-styles.css

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188534. gribozavr added a comment. Separated user and developer documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov added a comment. It feels we have two groups of docs here, do you think it would be useful to split them more explicitly? Specifically, we have: 1. User documentation - Getting started with clangd - Features 2. Developer documentation - Protocol extensions - Compiling

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:41 + +**(New in v9)** +If a missing symbol was seen in a file you've edited recently, clangd will It feels wrong to have announcements of the `9.0` features in the `8.0`

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188531. gribozavr added a comment. Herald added a reviewer: serge-sans-paille. Added custom CSS for the details tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188527. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files: clang-tools-extra/docs/clangd/ApplyClangTidyFixInVSCode.gif

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental `-background-index` command line argument. With + this feature enabled, clangd incrementally builds an index of

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr marked 4 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental `-background-index` command line argument. With + this feature enabled, clangd incrementally builds an index of

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188521. gribozavr marked 2 inline comments as done. gribozavr added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov added a reviewer: ioeric. ilya-biryukov added a comment. Still looking at it, a few quick notes. Also added ioeric for an extra pair of eyes (it's a large change!). Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. The text was written mostly by Sam McCall, screenshots are mostly made by me. Repository: