This revision was automatically updated to reflect the committed changes.
Closed by commit rC355608: [PR40778][Sema] Adjust addr space of operands in
builtin operators. (authored by stulova, committed by ).
Herald added a subscriber: kristina.
Herald added a project: clang.
Changed prior to
rjmccall added a comment.
Looks great, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58719/new/
https://reviews.llvm.org/D58719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia updated this revision to Diff 189527.
Anastasia added a comment.
Herald added a subscriber: jdoerfert.
I now create overloads for all address spaces that are being called.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58719/new/
https://reviews.llvm.org/D58719
Files:
rjmccall added a comment.
I think the right model is that a builtin operator candidate exists for all
possible address-space qualifiers on the pointer/reference pointee, and it
should be straightforward to only actually add candidates for the qualifier
used by the corresponding operand.
Anastasia updated this revision to Diff 188566.
Anastasia edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58719/new/
https://reviews.llvm.org/D58719
Files:
lib/Sema/SemaOverload.cpp
test/CodeGenOpenCLCXX/addrspace-operators.cl
Index:
Anastasia created this revision.
Anastasia added reviewers: rjmccall, ebevhan.
Adjust address space for references and pointer operands of builtin operators.
Currently this patch only changes addr space for OpenCL in assignment operator,
that is needed to fix the bug in the testcase reported
