This revision was automatically updated to reflect the committed changes.
Closed by commit rL355266: [clang-format] clang-format off/on not respected
when using C Style comments (authored by paulhoad, committed by ).
Herald added a project: LLVM.
Changed prior to commit:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58819/new/
https://reviews.llvm.org/D58819
___
cfe-commits mailing list
JonasToth added inline comments.
Comment at: clang/lib/Format/Format.cpp:1792
+else if (Trimmed == "// clang-format on" ||
+ Trimmed == "/* clang-format on */")
FormattingOff = false;
MyDeveloperDay wrote:
> JonasToth wrote:
> > Should we
MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/Format.cpp:1792
+else if (Trimmed == "// clang-format on" ||
+ Trimmed == "/* clang-format on */")
FormattingOff = false;
JonasToth added inline comments.
Comment at: clang/lib/Format/Format.cpp:1792
+else if (Trimmed == "// clang-format on" ||
+ Trimmed == "/* clang-format on */")
FormattingOff = false;
Should we allow
```
/* clang-format off
It is just
MyDeveloperDay updated this revision to Diff 188931.
MyDeveloperDay added a comment.
Fix negative test case
support the same /*clang-format off*/ in the sort includes that
the TokenLexer supports.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58819/new/
https://reviews.llvm.org/D58819
MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.
Comment at: clang/unittests/Format/SortIncludesTest.cpp:132
+ "#include \n"
+ "/* clang-format off */\n"
+ "#include \n"
alexfh
alexfh added inline comments.
Comment at: clang/unittests/Format/SortIncludesTest.cpp:132
+ "#include \n"
+ "/* clang-format off */\n"
+ "#include \n"
Add a test with `/* clang-format officially supports C++ */` ;)
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: djasper, klimek, JonasToth, krasimir.
MyDeveloperDay added projects: clang, clang-tools-extra.
If the clang-format on/off is in a /* comment */ then the sorting of headers is
not ignored
PR40901 -
