subject:"\[PATCH\] D58827\: \[Sema\]\[NFCI\] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction"

[PATCH] D58827: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction

2019-03-25 Thread Phabricator via Phabricator via cfe-commits

This revision was automatically updated to reflect the committed changes. Closed by commit rL356925: [Sema][NFCI] Dont allocate storage for the various CorrectionCandidateCallback… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D58827: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction

2019-03-18 Thread Reid Kleckner via Phabricator via cfe-commits

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think this is worth the complexity of the repeated clone methods. lgtm Comment at: lib/Sema/SemaType.cpp:5911 ExprResult AddrSpace = S.ActOnIdExpression( -