[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rC359516: [Diagnostics] Support -Wtype-limits for GCC compatibility (authored by xbolva00, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 updated this revision to Diff 197216. xbolva00 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 Files: include/clang/Basic/DiagnosticGroups.td test/Sema/compare.c test/Sema/tautological-constant-compare.c

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D58841#1483128 , @xbolva00 wrote: > Thanks for the review! If the patch is fine, please approve it. Sure thing! (Phab doesn't permit approving a

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ok, reclaiming patch. Thanks for the review! If the patch is fine, please approve it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

rsmith added a comment. > xbolva00 abandoned this revision. Do you not want to pursue this any more? This seems reasonable to me, and is in line with other cases where we have diagnostic flags as aliases to GCC's similar-but-not-quite-the-same flags (eg, GCC's `-Wnoexcept-type` doesn't fire

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

aaron.ballman added a comment. I worry a little bit about our -Wtype-limits getting out of sync from GCC's due to making it a synonym for -Wtautological-constant-in-range-compare, but I'm also at a loss for why these two should ever have different functionality. I think I'm okay with this, but

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ping @aaron.ballman @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits : DiagGroup<"type-limits",

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits : DiagGroup<"type-limits", [TautologicalInRangeCompare]>; def

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 marked an inline comment as done. xbolva00 added a comment. Ok, if concers Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits :

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

lebedev.ri added a reviewer: thakis. lebedev.ri resigned from this revision. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 updated this revision to Diff 188957. xbolva00 added a comment. Remove from -Wextra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/Sema/compare.c

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. See D41512 , rC322901 , D51545 . Comment at:

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D58841 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/Sema/compare.c