[PATCH] D58930: Add XCOFF triple object format type for AIX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355989: Add XCOFF triple object format type for AIX (authored by jasonliu, committed by ). Herald added a subscriber: kris

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added a comment. @jasonliu, you have had a number of patches committed into the project already (D22698 , D22702 , D34649 ). Please go ahead with requesting commit access, a

[PATCH] D58930: Add XCOFF triple object format type for AIX

sfertile accepted this revision. sfertile added a comment. LGTM. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; jasonliu wrote: > sfertile wrote: > > jasonliu w

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189713. jasonliu added a comment. Share the same "unsupported error" message with WASM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/Back

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[PATCH] D58930: Add XCOFF triple object format type for AIX

sfertile added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; jasonliu wrote: > JDevlieghere wrote: > > See previous comment. > It is certain tha

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; davide wrote: > hubert

[PATCH] D58930: Add XCOFF triple object format type for AIX

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189514. jasonliu added a comment. Address comments in last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp clang

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; JDevlieghere wrote: >

[PATCH] D58930: Add XCOFF triple object format type for AIX

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; jasonliu wrote: > JDevlieghere w

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; JDevlieghere wrote: > See previous comme

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 3 inline comments as done. jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; JDevlieghere wrote: > This is confusing, you s

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[PATCH] D58930: Add XCOFF triple object format type for AIX

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; --

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189387. jasonliu added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[PATCH] D58930: Add XCOFF triple object format type for AIX

apaprocki added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; No need to be `sorry:` :) This shou

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Triple.cpp:537 return StringSwitch(EnvironmentName) +// FIXME: We have to put XCOFF before COFF; +// perhaps an order-independent pattern matching is desired? If the conclusion

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, sfertile, chandlerc, apaprocki. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, aheejin, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. This patch adds an XCOFF tri