[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

This revision was automatically updated to reflect the committed changes. Closed by commit rC357285: [AMDGPU] Switch default DWARF version to 5 (authored by scott.linder, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

scott.linder updated this revision to Diff 192688. scott.linder added a comment. Add a test to confirm split-dwarf is supported for the amdhsa OS in the driver. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 Files:

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

dblaikie added a comment. In D59008#1442962 , @probinson wrote: > In D59008#1442515 , @dblaikie wrote: > > > In D59008#1442256 , @t-tye wrote: > > > > > In D59008#1442014

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

probinson added a comment. In D59008#1442515 , @dblaikie wrote: > In D59008#1442256 , @t-tye wrote: > > > In D59008#1442014 , @dblaikie > > wrote: > > > > > In

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

dblaikie added a comment. In D59008#1442256 , @t-tye wrote: > In D59008#1442014 , @dblaikie wrote: > > > In D59008#1441903 , @t-tye wrote: > > > > > LGTM > > > > > > Do we

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

kzhuravl accepted this revision. kzhuravl added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

t-tye added a comment. In D59008#1442014 , @dblaikie wrote: > In D59008#1441903 , @t-tye wrote: > > > LGTM > > > > Do we know the state of split DWARF and DWARF compression for DWARF 5 > > (compared to DWARF 2)? >

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

dblaikie added a comment. In D59008#1441903 , @t-tye wrote: > LGTM > > Do we know the state of split DWARF and DWARF compression for DWARF 5 > (compared to DWARF 2)? State of them in what sense? Compression is pretty orthogonal to any DWARF version -

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

scott.linder added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

scott.linder created this revision. scott.linder added reviewers: kzhuravl, t-tye. Herald added subscribers: cfe-commits, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely. Herald added a project: clang. Reverts r337612. The issues that cropped up with the last attempt appear to have gone away.