[PATCH] D59118: creduce script for clang crashes

arichardson added a comment. In case anyone is interested, for the CHERI fork of LLVM/Clang I added a similar script that contains additional features such as inferring the crash message (so that you get the minimal reproducer for the issue that you are trying to reduce and not some obscure

[PATCH] D59118: creduce script for clang crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rC355944: Add a creduce script for clang crashes (authored by gbiv, committed by ). Changed prior to commit: https://reviews.llvm.org/D59118?vs=190285=190294#toc Repository: rC Clang CHANGES SINCE

[PATCH] D59118: creduce script for clang crashes

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. I think that addresses all of the concerns people have put forward; given rnk's comment about one more round of fixes, this LGTM. Will check this in for you shortly.

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190285. akhuang marked 6 inline comments as done. akhuang added a comment. style edits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59118: creduce script for clang crashes

thakis added a comment. (A few python style comments; feel free to ignore, and feel free to land no matter what you do with the comments.) Comment at: clang/utils/creduce-clang-crash.py:1 +#!/usr/bin/env python +# A tool that calls C-Reduce to create a minimal reproducer for

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190189. akhuang added a comment. add interestingness test sanity check; revive ctrl-c hack CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59118: creduce script for clang crashes

rnk added inline comments. Comment at: clang/utils/creduce-clang-crash.py:1 +#!/usr/bin/env python +# A tool that calls C-Reduce to create a minimal reproducer for clang crashes george.burgess.iv wrote: > nit: please specify a python version here, since the

[PATCH] D59118: creduce script for clang crashes

george.burgess.iv added a comment. > I think we should do one more round of fixes, we can commit that for you, and > then move on to the next steps +1. This looks good to me with outstanding nits fixed > and filter out the # lines afterwards. AIUI, the very-recently-merged

[PATCH] D59118: creduce script for clang crashes

rnk added a subscriber: gbiv. rnk added a comment. @gbiv already got all my shell quoting comments. I think we should do one more round of fixes, we can commit that for you, and then move on to the next steps. Comment at: clang/utils/creduce-clang-crash.py:109 +

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190164. akhuang added a comment. fixed diff with style edits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: .arcconfig clang/utils/creduce-clang-crash.py Index:

[PATCH] D59118: creduce script for clang crashes

joerg added a comment. For it to be really useful for the majority of bugs, it would be nice to figure out automatically how to get the preprocessing step done and filter out the # lines afterwards. That part alone significantly cuts down the creduce time. CHANGES SINCE LAST ACTION

[PATCH] D59118: creduce script for clang crashes

lebedev.ri added a comment. The new diffs should not be relative to the previously uploaded diff, but to the git master/svn trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 ___ cfe-commits

[PATCH] D59118: creduce script for clang crashes

akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:43 + # Get crash output + p = subprocess.Popen(build_script, + stdout=subprocess.PIPE, george.burgess.iv wrote: > nit: can replace with

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190126. akhuang marked 15 inline comments as done. akhuang added a comment. Addressed readability comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py

[PATCH] D59118: creduce script for clang crashes

george.burgess.iv added a comment. Thanks for this! Functionally, this looks good. My comments are mostly just simplicity/readability nitpicks. Comment at: clang/utils/creduce-clang-crash.py:36 + # Get clang call from build script + cmd = None + with open(build_script,

[PATCH] D59118: creduce script for clang crashes

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a script that calls C-Reduce on an input file and given the clang crash script, which is used to