[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`

2019-03-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC355987: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);` (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59197/new/

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

2019-03-11 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D59197#1424832 , @jordan_rose wrote: > I'm no Clang serialization expert but this makes sense to me. It's consistent > with all the other statement visitor methods. Thank you. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

2019-03-11 Thread Jordan Rose via Phabricator via cfe-commits
jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. I'm no Clang serialization expert but this makes sense to me. It's consistent with all the other statement visitor methods. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

2019-03-11 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D59197#1424644 , @aprantl wrote: > How can this change be NFC? `VisitStmt()` is empty currently, there is currently no data serialized by the `Stmt` itself. D59214 changes that.

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

2019-03-11 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. How can this change be NFC? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59197/new/ https://reviews.llvm.org/D59197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`

2019-03-10 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri created this revision. lebedev.ri added reviewers: arphaman, sammccall, smeenai, aprantl, rsmith. lebedev.ri added a project: clang. These ObjC AST classes inherit from Stmt, but don't call `VisitStmt(S);`. Some were founded with help of existing tests (with `NumStmtFields` bumped to