This revision was automatically updated to reflect the committed changes.
Closed by commit rC356450: [OpenCL] Improved testing of default header.
(authored by stulova, committed by ).
Herald added a project: clang.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D5948
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:57-65
char f(char x) {
-#if __OPENCL_C_VERSION__ != CL_VERSION_2_0
+#if !defined(__OPENCL_CPP_VERSION__) && (__OPENCL_C_VERSION__ !=
CL_VERSION_2_0)
retur
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
OpenCL C++ part looks good. Thanks!
Comment at: test/Headers/opencl-c-header.cl:57-65
char f(char x) {
-#if __OPENCL_C_VERSION__ != CL_VERSION_2_0
+#if !defined(__OPENCL_CPP_V
Anastasia marked an inline comment as done.
Anastasia added inline comments.
Comment at: test/Driver/include-default-header.cl:2
+// RUN: %clang -save-temps -x cl -Xclang -cl-std=CL2.0 -Xclang
-finclude-default-header -emit-llvm -S -### %s 2>&1 | FileCheck %s
+// RUN: %clang -sa
Anastasia updated this revision to Diff 191100.
Anastasia added a comment.
Moved testing of default header in C++ mode to test/Headers/opencl-c-header.cl
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59486/new/
https://reviews.llvm.org/D59486
Files:
test/Driver/include-default-header
bader added a comment.
I see seven OpenCL C tests using -finclude-default-header option and AFAIK,
only test/Driver/include-default-header.cl doesn't parse it. Could you also
update OpenCL C tests?
I think clang/test/Headers/opencl-c-header.cl and
test/Driver/include-default-header.cl fully cov
Anastasia created this revision.
Anastasia added a reviewer: bader.
Herald added subscribers: ebevhan, yaxunl.
Moved testing of the default header into the Driver test and also added a test
line for C++ mode in printf test.
Follow up from https://reviews.llvm.org/D59219
https://reviews.llvm.or
