This revision was automatically updated to reflect the committed changes.
Closed by commit rC356663: Permit redeclarations of a builtin to specify
calling convention. (authored by erichkeane, committed by ).
Herald added a subscriber: kristina.
Herald added a project: clang.
Repository:
rC
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59560/new/
https://reviews.llvm.org/D59560
___
cfe-commits mailing list
erichkeane updated this revision to Diff 191483.
erichkeane added a comment.
Woops! Look like I left without actually changing the revision *shame*.
Also, I was an idiot about SemaType, please disregard my previous comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59560/new/
erichkeane updated this revision to Diff 191403.
erichkeane added a comment.
As @rnk suggested, switch to an enum. SemaType.cpp unfortunately has Sema as a
forward declaration, so it has to use integers.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59560/new/
erichkeane marked an inline comment as done.
erichkeane added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:3144
+ << FunctionType::getNameForCallConv(NewTypeInfo.getCC())
+ << 3 /*on builtin function*/;
+ NewTypeInfo =
rnk added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:3144
+ << FunctionType::getNameForCallConv(NewTypeInfo.getCC())
+ << 3 /*on builtin function*/;
+ NewTypeInfo = NewTypeInfo.withCallingConv(OldTypeInfo.getCC());
You can make
erichkeane created this revision.
erichkeane added a reviewer: rnk.
Herald added a subscriber: javed.absar.
After https://reviews.llvm.org/rL355317 we noticed that quite a decent
amount of code redeclares builtins (memcpy in particular, I believe
reduced from an MSVC header) with a calling
