[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

kadircet abandoned this revision. kadircet added a comment. It is incorporated into D59639 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59599/new/ https://reviews.llvm.org/D59599

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

kadircet updated this revision to Diff 194470. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59599/new/ https://reviews.llvm.org/D59599 Files: clangd/AST.cpp

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

Eugene.Zelenko added inline comments. Comment at: clangd/AST.cpp:86 else if (auto *Cls = llvm::dyn_cast()) { -if (auto STL = Cls->getTypeAsWritten() - ->getTypeLoc() - .getAs()) { - llvm::SmallVector ArgLocs; -

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/AST.cpp:95 +} else { + // FIXME: Cls->getTypeAsWritten might return null in some cases, e.g. + // clang sees first sees a

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59599 Files: clangd/AST.cpp