erik.pilkington closed this revision.
erik.pilkington added a comment.
Landed in r357040. (I forgot to write Differential revision:!)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59670/new/
https://reviews.llvm.org/D59670
___
cfe-commits m
rjmccall accepted this revision.
rjmccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaExpr.cpp:15692
+ MaybeODRUseExprSet LocalMaybeODRUseExprs;
+ std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs);
+
e
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:15692
+ MaybeODRUseExprSet LocalMaybeODRUseExprs;
+ std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs);
+
rjmccall wrote:
> It looks like `SmallPtrSet`'s move constructor does actual
erik.pilkington updated this revision to Diff 192300.
erik.pilkington marked an inline comment as done.
erik.pilkington added a comment.
Add an assert.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59670/new/
https://reviews.llvm.org/D59670
Files:
clang/include/clang/Sema/Sema.h
cl
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:15692
+ MaybeODRUseExprSet LocalMaybeODRUseExprs;
+ std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs);
+
It looks like `SmallPtrSet`'s move constructor does actually guarantee to leave
th
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, rsmith.
Herald added subscribers: dexonsmith, jkorous.
Herald added a project: clang.
`MarkVarDeclODRUsed` indirectly calls `captureInBlock`, which creates a copy
expression. The copy expression is insulated in it's
