[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert updated this revision to Diff 196149. aaronpuchert added a comment. Introduce -split-dwarf-output instead to mirror the behavior of llc, which already allows to set the attribute separately from the output file name. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#1465975 , @aaronpuchert wrote: > In D59673#1461983 , @dblaikie wrote: > > > Sure, I think the naming's a bit weird (but hard to come up with good names > > for any of this) > >

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D59673#1461983 , @dblaikie wrote: > Sure, I think the naming's a bit weird (but hard to come up with good names > for any of this) Agreed, `-split-dwarf-output` is pretty

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#1460605 , @aaronpuchert wrote: > Ok, here is an idea. We introduce `-split-dwarf-output` in Clang instead of > `-fsplit-dwarf-dwo-name-attr`. If given, it overrides the output file name > for the Split DWARF file,

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. Ok, here is an idea. We introduce `-split-dwarf-output` in Clang instead of `-fsplit-dwarf-dwo-name-attr`. If given, it overrides the output file name for the Split DWARF file, which we otherwise take from `-split-dwarf-file`. The option is obviously incompatible

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. In D59673#1452269 , @dblaikie wrote: > Ah, fair. You could actually test the dwo_name is accurate in the .dwo file > (I added the dwo_name to the .dwo file so that multi-level dwp error messages > could be more informative)

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#143 , @aaronpuchert wrote: > In D59673#1438716 , @dblaikie wrote: > > > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > > debug_info section and

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert updated this revision to Diff 191813. aaronpuchert added a comment. Use llvm-dwarfdump to inspect debug info, remove unneeded flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files:

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. In D59673#1438716 , @dblaikie wrote: > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > debug_info section and test the dwo_name there (rather than dumping hex) I didn't know about llvm-dwarfdump,

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. Pleasue include mention of the bug (PR40276) in the commit message & clarify that while this is useful for some remote compilation models, it's not strictly necessary/the only way to do it (a remote compilation model that keeps relative paths and uses compilation-dir

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, echristo. Herald added subscribers: cfe-commits, jdoerfert, aprantl. Herald added a project: clang. With Split DWARF the resulting object file (then called skeleton CU) contains the file name of another ("DWO") file with