[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

dschuff added a comment. Reverted in rG039be787914610c28cba45c4557454e0a96939ab . Caused a strange error with the waterfall sysroot's build of libcxx: https://logs.chromium.org/logs/wasm/buildbucket/cr-buildbucket.appspot.com/

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

This revision was automatically updated to reflect the committed changes. Closed by commit rC356953: [WebAssembly] Don't use default GetLinkerPath (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D59743?vs=192126&id=192201#toc Repository: rC Clang CHANGES

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.h:89 - const char *getDefaultLinker() const override { -return "ld.lld"; - } + const char *getDefaultLinker() const override { return "ld.lld"; } phosek wrote: > This seems u

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 updated this revision to Diff 192126. sbc100 marked 4 inline comments as done. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59743/new/ https://reviews.llvm.org/D59743 Files: clang/lib/Driver/ToolChains/

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 updated this revision to Diff 192125. sbc100 marked an inline comment as done. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59743/new/ https://reviews.llvm.org/D59743 Files: clang/lib/Driver/ToolChains/

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.h:89 - const char *getDefaultLinker() const override { -return "ld.lld"; - } + const char *getDefaultLinker() co

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 created this revision. Herald added subscribers: cfe-commits, atanasyan, jrtc27, sunfish, aheejin, jgravelle-google, sdardis, dschuff. Herald added a project: clang. We can't (don't want to) honor the same set of "-fuse-ld" flags with WebAssembly since the ELF linkers (ld.lld, ld.gnu, etc)