a_sidorin added a comment.
Post-LGTM with some stylish nits.
Comment at: cfe/trunk/lib/AST/ASTImporter.cpp:1950
+ // Eliminate a potential failure point where we attempt to re-import
+ // something we're trying to import while completin ToEnum
+ if (Decl *ToOrigin =
This revision was automatically updated to reflect the committed changes.
shafik marked an inline comment as done.
Closed by commit rL357100: [ASTImporter] Fix IsStructuralMatch specialization
for EnumDecl to prevent re… (authored by shafik, committed by ).
Herald added a project: LLVM.
Herald
shafik marked 2 inline comments as done.
shafik added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1951
+ // something we're trying to import while completin ToEnum
+ Decl *ToOrigin = Importer.GetOriginalDecl(ToEnum);
+
JDevlieghere wrote:
> ```
> if
shafik updated this revision to Diff 192466.
shafik added a comment.
Fixes based on comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59845/new/
https://reviews.llvm.org/D59845
Files:
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59845/new/
https://reviews.llvm.org/D59845
___
cfe-commits mailing list
JDevlieghere added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1951
+ // something we're trying to import while completin ToEnum
+ Decl *ToOrigin = Importer.GetOriginalDecl(ToEnum);
+
```
if (Decl *ToOrigin = Importer.GetOriginalDecl(ToEnum))
if
shafik added a comment.
LLDB regression test that goes with this fix: https://reviews.llvm.org/D59847
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59845/new/
https://reviews.llvm.org/D59845
___
cfe-commits mailing list
shafik created this revision.
shafik added reviewers: martong, teemperor, friss, a_sidorin.
Herald added subscribers: jdoerfert, rnkovacs.
We may try and re-import an EnumDecl while trying to complete it in
`IsStructuralMatch(...)` specialization for `EnumDecl`. This change mirrors a
similar
