[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-30 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added inline comments. Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3 + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal jsji wrote: >

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a subscriber: chandlerc. rjmccall added a comment. @chandlerc, I hate to do this to you, but licensing question. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-23 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. Thanks @MaskRay for help fixing and review! Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3 + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-23 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. In D59924#1475363 , @MaskRay wrote: > May I ask why the mmintrin.h emulation layer must be added to the clang > resource directory? Why can't it be provided as a standalone library like > https://github.com/intel/ARM_NEON_2_x86_SSE

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3 + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal This is not

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. May I ask why the mmintrin.h emulation layer must be added to the clang resource directory? Why can't it be provided as a standalone library like https://github.com/intel/ARM_NEON_2_x86_SSE ? Will you add SSE/AVX/AVX512 emulation layer to the clang resource directory

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. You use `%clang` (clang driver) because the test needs `-internal-isystem $resource_dir/include/ppc_wrappers`. A default release build of llvm sets `LLVM_ENABLE_ASSERTIONS` to off, the clang driver defaults to `-fdiscard-value-names`. This caused the test to break. I

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power (authored by chaofan, committed by ). Changed prior to commit: https://reviews.llvm.org/D59924?vs=194446=196182#toc

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-15 Thread Jinsong Ji via Phabricator via cfe-commits
jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-10 Thread Chaofan Qiu via Phabricator via cfe-commits
qiucf marked an inline comment as done. qiucf added a comment. Part of a function signature can also match where it is called, so the test failed. I did the changes to pass the test but diff file was generated locally so it didn't contain this change. Sorry for the mistake. Repository: rC

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-09 Thread Chaofan Qiu via Phabricator via cfe-commits
qiucf updated this revision to Diff 194446. qiucf added a comment. Fix error about a mismatch in mmintrin test cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-09 Thread Jinsong Ji via Phabricator via cfe-commits
jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. Please make sure you run all test before updating patch! Comment at: clang/test/CodeGen/ppc-mmintrin.c:23 +// CHECK: i64 @_mm_packs_pu16(i64 [[REG1:[0-9a-zA-Z_%.]+]],

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-04-09 Thread Chaofan Qiu via Phabricator via cfe-commits
qiucf updated this revision to Diff 194253. qiucf retitled this revision from "[PowerPC][Clang] Port MMX intrinsics and basic test cases to Power" to "[PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power". qiucf edited the summary of this revision. qiucf added a comment. - Add

[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

2019-04-09 Thread Chaofan Qiu via Phabricator via cfe-commits
qiucf marked 2 inline comments as done. qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:22 + if (getArch() != llvm::Triple::ppc && + !DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) && +

[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

2019-04-08 Thread Jinsong Ji via Phabricator via cfe-commits
jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. Since we are adding new headers that is not originated by this patch, please also update the description (and commit message) to include who actually contributed to `mmintrin.h` and

[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

2019-03-28 Thread Chaofan Qiu via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: hfinkel, nemanjai, jsji, rsmith. Herald added subscribers: cfe-commits, jdoerfert, kbarton, mgorny. Herald added a project: clang. This patch is for porting existing headers which include x86 intrinsics (MMX, SSE, SSE2, etc.) implementation to