[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC358288: [AST][NFC] Add const children() accessors to all AST nodes (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D60029?vs=193288=194897#toc Repository:

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-12 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. Yes, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-12 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. Sorry for the delay. Thanks a lot for the patch! Some of these casts are rather questionable. However this has nothing to do with your patch since you are just adding the const-qualified version of `children()`. Therefore I believe this patch looks good. Do you want

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-10 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-02 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas updated this revision to Diff 193288. nicolas retitled this revision from "Add const children() accessors to Stmts" to "Add const children() accessors to all AST nodes.". nicolas edited the summary of this revision. nicolas added a comment. Added children() const to all AST nodes.