[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

2019-04-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC357516: [Sema] Fix a use-after-deallocate of a ParsedAttr (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60101?vs=193185&id=193348#toc Repository: rC Clang CH

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

2019-04-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Thanks for this! Comment at: clang/include/clang/Sema/ParsedAttr.h:896 + void takeOneFrom(ParsedAttributes &attrs, ParsedAtt

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

2019-04-01 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added a reviewer: aaron.ballman. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. `moveAttrFromListToList` only makes sense when moving an attribute to a list with a pool that's either equivalent, or has a shorter