[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

2019-04-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC358321: [analyzer] Escape pointers stored into top-level parameters with destructors. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60112?vs=193229&id=194993

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

2019-04-10 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Okay, I played around with this patch, I see now where this is going! LGTM! > Do you think i should document it somehow? Aye, the description you gave was enlightening, thanks! If you ca

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

2019-04-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ marked an inline comment as done. NoQ added a comment. In D60112#1451198 , @Szelethus wrote: > Woah, the code looks amazing, cheers on the refactoring! I'll be honest, I'm > struggling a bit with the sentence "we're now in the top frame". In order, I

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

2019-04-02 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Woah, the code looks amazing, cheers on the refactoring! I'll be honest, I'm struggling a bit with the sentence "we're now in the top frame". In order, I don't understand what does - we - now - in the top frame mean. "Top-level argument" is another one -- Do we have

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

2019-04-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Writing stuff into an argum