[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-07-17 Thread Justin Hibbits via Phabricator via cfe-commits
jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. Herald added a subscriber: shchenz. Looks fine to me. Since it can be turned off, I don't see a problem if it causes issues. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I did this in rC365862 with a test after my refactoring of the interface rC365860 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-07-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Herald added a subscriber: wuzish. I would write the following test (I can commit that for you) diff --git c/test/Driver/frame-pointer-elim.c w/test/Driver/frame-pointer-elim.c index 6fcd3eb75a..c2e9ccb225 100644 --- c/test/Driver/frame-pointer-elim.c +++

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-04-16 Thread George Koehler via Phabricator via cfe-commits
kernigh added a comment. I'm stuck. I didn't put a test in this patch because I can't run the tests yet. So far, I can build a clang executable but can't build the rest of the project. I won't run the tests without a complete build, and I won't edit the tests without running them. I had

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-04-07 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. George, look at adding some appropriate entries to test/Driver/frame-pointer-elim.c Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/D60335 ___ cfe-commits

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-04-05 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. test coverage? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/D60335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-04-05 Thread George Koehler via Phabricator via cfe-commits
kernigh created this revision. kernigh added reviewers: joerg, brad, cfe-commits. Herald added subscribers: jsji, krytarowski, nemanjai. Herald added a project: clang. This enables -fomit-frame-pointer when optimizing code for all PowerPC targets, instead of only Linux and NetBSD. I mailed this