[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-26 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added subscribers: hctim, vitalybuka. vitalybuka added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12035 -- Testing: 14692 tests, 96 threads -- Testing: FAIL: Clang :: AST/float16.cpp (132 of 14692) TEST

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-26 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. fixed with r359366 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-26 Thread Javed Absar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC359348: [AArch64] Add support for MTE intrinsics (authored by javed.absar, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60485?vs=196297=196915#toc

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-25 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover accepted this revision. t.p.northover added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131 +// Although it is possible to supply a different return +// address (first arg) to this intrinsic,

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-25 Thread Javed Absar via Phabricator via cfe-commits
javed.absar marked an inline comment as done. javed.absar added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131 +// Although it is possible to supply a different return +// address (first arg) to this intrinsic, for now we set +// return address same

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-24 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added inline comments. Comment at: include/clang/Sema/Sema.h:10762 bool AllowName); + bool SemaBuiltinARMMemoryTaggingCall(unsigned BuiltinID, CallExpr *TheCall); public: Slightly misaligned.

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-23 Thread Javed Absar via Phabricator via cfe-commits
javed.absar updated this revision to Diff 196297. javed.absar marked an inline comment as done. javed.absar added a comment. Hi Tim: Have made the changes as suggested. Please have a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 Files:

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-15 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer : Error< javed.absar wrote:

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-15 Thread Javed Absar via Phabricator via cfe-commits
javed.absar marked 2 inline comments as done. javed.absar added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer :

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-15 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer : Error< I think these

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-15 Thread Javed Absar via Phabricator via cfe-commits
javed.absar updated this revision to Diff 195112. javed.absar added a comment. Tests merged as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 Files: include/clang/Basic/BuiltinsAArch64.def

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Do we need a separate file for that one "__arm_mte_ptrdiff" test? Wouldn't it be easier to wrap the whole function in "__cplusplus" and put it in the same file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-09 Thread Javed Absar via Phabricator via cfe-commits
javed.absar created this revision. javed.absar added reviewers: DavidSpickett, olista01. Herald added a subscriber: kristof.beyls. This patch provides intrinsics support for Memory Tagging Extension (MTE), which was introduced with the Armv8.5-a architecture. These intrinsics are available