[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-06-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-31 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Added lit tests for the simple (`Decl`) cases. The `Expr` and type related changes are more tricky to do. But I do not like this approach to add new tests because the test function in D60463 does almost the same thing for every import

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-31 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 202438. balazske added a comment. - Import BraceRange of EnumDecl. - Added lit tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 Files: lib/AST/ASTImporter.cpp

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-30 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik requested changes to this revision. shafik added a comment. This revision now requires changes to proceed. Actually I was mistaken, we can see the difference for `EnumDecl` and `ClassTemplateSpecializationDecl` as well. For `EnumDecl` before: EnumDecl 0x7fd0ae884800 col:6 referenced

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-30 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. It looks like that the same test can be applied as in D60463 but check only the first line of the AST dump. The first line contains information about the actual Decl only. This checks less than checking the full AST dump but finds

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-29 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I think the AST dump for `EnumDecl` and `ClassTemplateSpecializationDecl` should be dumping the missing `SourceLocations` but I am having trouble tracking down where that should be done. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-29 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. So an alternative to testing could be matching the AST output from a `clang-import-test` like we did here: https://reviews.llvm.org/D61140 although it unfortunately looks like only only the AST dump of `NamespaceDecl` output the `SourceLocation` you are fixing, see it

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-29 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked 3 inline comments as done. balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:6129 if (Error Err = -ImportTemplateArgumentListInfo(E->template_arguments(), ToTAInfo)) +ImportTemplateArgumentListInfo(E->getLAngleLoc(),

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-29 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. There is a test for the SourceLocation import in https://reviews.llvm.org/D60463 (after this patch is applied that test should not fail and the "return" statement is to be removed). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-28 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I don't see any regressions but I am a little uncomfortable since there are no tests. So I would feel better if this was split into three parts: Namespaces, Enums and Templates. Are there small test programs that fail due to the missing data? We can add them as

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-05-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 201521. balazske added a comment. - Import BraceRange of EnumDecl. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

2019-04-10 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter contained wrong or missing imports of