milianw added a comment.
thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60672/new/
https://reviews.llvm.org/D60672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC361234: [libclang] visit c++14 lambda capture init
expressions (authored by nik, committed by ).
Changed prior to
milianw added a comment.
Do you have commit rights? Can you push that for me?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60672/new/
https://reviews.llvm.org/D60672
___
cfe-commits mailing list
nik added a comment.
> Are you sure you have compiled this patch? If I comment out the visit of the
> InitExpr in CIndex.cpp again, then I get the same failure as you...
Huch, I've indeed somehow missed to compile. Sorry for that. Works fine after
compilation :)
LGTM.
Repository:
rG LLVM
milianw added a comment.
@nik odd, it works for me, I just switched to master (previously I used the 8x
release branch) and applied this patch and build it all. Then I run:
$ make && ./bin/llvm-lit
~/projects/src/llvm-project/clang/test/Index/cxx14-lambdas.cpp
makeobj[0]: Entering
nik added a comment.
Tests do not pass on current trunk:
/d2/llvm/trunk/builds/DebugShared % bin/llvm-lit -a
/d2/llvm/trunk/source/tools/clang/test/Index/cxx14-lambdas.cpp
llvm-lit: /d2/llvm/trunk/source/utils/lit/lit/llvm/config.py:341: note: using
clang:
milianw created this revision.
milianw added reviewers: clang-c, cfe-commits, hokein, nik, yvvan, marcobubke.
Herald added a subscriber: arphaman.
Herald added a project: clang.
Previously, libclang users could visit the non-init C++11 lambda
captures, e.g. `[foo]`. But C++14 init-captures such
