[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

dmgreen added a comment. Hello. Hopefully fixed in rC362814 ! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

thakis added a comment. The test is failing on some bots, e.g. http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/13430/steps/test-stage1-compiler/logs/stdio /home/buildslave/buildslave1a/clang-with-lto-ubuntu/llvm.src/tools/clang/test/Preprocessor/arm-target-features.c:762:20:

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362806: [ARM] Add ACLE feature macros for MVE (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer added a comment. Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer updated this revision to Diff 203555. SjoerdMeijer added a comment. Yep, sorry, missed that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/ARM.h

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

ostannard added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:465 + MVE |= MVE_INT | MVE_FP; + HW_FP |= HW_FP_SP | HW_FP_HP; } SjoerdMeijer wrote: > ostannard wrote: > > Does this also need to set FPU and HasLegalHalfType? > Yep,

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer updated this revision to Diff 203522. SjoerdMeijer added a comment. Set FullFP16 for +mve.fp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/ARM.h

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:465 + MVE |= MVE_INT | MVE_FP; + HW_FP |= HW_FP_SP | HW_FP_HP; } ostannard wrote: > Does this also need to set FPU and

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

ostannard added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:465 + MVE |= MVE_INT | MVE_FP; + HW_FP |= HW_FP_SP | HW_FP_HP; } Does this also need to set FPU and HasLegalHalfType? CHANGES SINCE LAST ACTION

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer updated this revision to Diff 203507. SjoerdMeijer added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/ARM.h

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

t.p.northover added a comment. Could you add some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. If MVE is present at all, then the macro __ARM_FEATURE_MVE is defined to a value which has bit 0