[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358605: [clangd] Recognize "don't include me directly" pattern, and suppress include… (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D60815?vs=195562&id=195

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:631 + +bool SymbolCollector::isSelfContainedHeader(FileID FID) { + // The real computation (which will be memoized). sammccall wrote: > ioeric wrote: > > sammccall wrote: > > > this has b

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:631 + +bool SymbolCollector::isSelfContainedHeader(FileID FID) { + // The real computation (which will be memoized). ioeric wrote: > sammcca

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall updated this revision to Diff 195562. sammccall added a comment. DontIncludeMePattern Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60815/new/ https://reviews.llvm.org/D60815 Files: clangd/index/SymbolCollector.cpp clangd/index/Symbol

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/index/SymbolCollector.cpp:631 + +bool SymbolCollector::isSelfContainedHeader(FileID FID) { + // The real computation (which will be memoized). --

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:602 +/// Returns None if includes should not be inserted for this file. +llvm::Optional +SymbolCollector::getIncludeHeader(llvm::StringRef QName, FileID FID)

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall updated this revision to Diff 195534. sammccall marked an inline comment as done. sammccall added a comment. remove leftover debugging Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60815/new/ https://reviews.llvm.org/D60815 Files: clang

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall updated this revision to Diff 195533. sammccall added a comment. unconfusing my git repo Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60815/new/ https://reviews.llvm.org/D60815 Files: clangd/index/SymbolCollector.cpp clangd/index/Sym

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Typically used with umbrella headers, e.g. GTK: #if !defined (__GTK_H_INSIDE__) && !defined (GTK_COMPILA