[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea abandoned this revision. gtbercea marked an inline comment as done. gtbercea added a comment. Replaced by: D61399 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

tra added a comment. In D60907#1484756 , @jdoerfert wrote: > I actually don't want to preinclude anything and my arguments are (mostly) > for the OpenMP offloading code path not necessarily Cuda. > Maybe to clarify, what I want is: > > 1. Make sure the

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added a comment. In D60907#1484529 , @hfinkel wrote: > In D60907#1483660 , @jdoerfert wrote: > > > In D60907#1483615 , @hfinkel wrote: > > > > > In D60907#1479370

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

tra added a comment. +1 to Hal's comments. @jdoerfert : > I'd even go as far as to argue that __clang_cuda_device_functions.h should > include the internal math.h wrapper to get all math functions. See also the > next comment. I'd argue other way around -- include

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

hfinkel added a comment. In D60907#1483660 , @jdoerfert wrote: > In D60907#1483615 , @hfinkel wrote: > > > In D60907#1479370 , @gtbercea > > wrote: > > > > > In

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added a comment. In D60907#1483615 , @hfinkel wrote: > In D60907#1479370 , @gtbercea wrote: > > > In D60907#1479142 , @hfinkel wrote: > > > > > In D60907#1479118

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

hfinkel added a comment. In D60907#1479370 , @gtbercea wrote: > In D60907#1479142 , @hfinkel wrote: > > > In D60907#1479118 , @gtbercea > > wrote: > > > > > Ping @hfinkel

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1159 + getToolChain().getTriple().isNVPTX()) +getToolChain().AddMathDeviceFunctions(Args, CmdArgs); + Here is another "NVPTX" specialization that I don't think we need. At

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea updated this revision to Diff 196725. gtbercea added a comment. - Update patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479142 , @hfinkel wrote: > In D60907#1479118 , @gtbercea wrote: > > > Ping @hfinkel @tra > > > The last two comments in D47849 indicated >

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479298 , @gtbercea wrote: > In D60907#1479142 , @hfinkel wrote: > > > In D60907#1479118 , @gtbercea > > wrote: > > > > > Ping @hfinkel

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479142 , @hfinkel wrote: > In D60907#1479118 , @gtbercea wrote: > > > Ping @hfinkel @tra > > > The last two comments in D47849 indicated >

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

hfinkel added a comment. In D60907#1479118 , @gtbercea wrote: > Ping @hfinkel @tra The last two comments in D47849 indicated exploration of a different approach, and one which still seems superior to this one. Can you

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. Ping @hfinkel @tra Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org