[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

2019-05-03 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL359864: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

2019-04-30 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. In D61147#1479932 , @rjmccall wrote: > I would also recommend that you go fix the warning to never fire on virtual > C++ methods. I tried building clang/llvm with -Wunused-parameter turned on and there are lots of places wher

[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

2019-04-30 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https://reviews.llvm.org/D61147 ___

[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

2019-04-30 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 197469. ahatanak retitled this revision from "[Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods" to "[Sema][ObjC] Disable -Wunused-parameter for ObjC methods". ahatanak edited the summary of this revision