mstorsjo marked an inline comment as done.
mstorsjo added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689
if ((Context.getTargetInfo().getCXXABI().isMicrosoft() ||
- Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment())
rnk added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689
if ((Context.getTargetInfo().getCXXABI().isMicrosoft() ||
- Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment())
&&
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rC359342: [MinGW] Dont let template instantiation
declarations cover nested classes (authored by mstorsjo, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Seems okay to me.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61175/new/
https://reviews.llvm.org/D61175
___
mstorsjo created this revision.
mstorsjo added reviewers: rnk, hans, smeenai.
Herald added a project: clang.
An explicit template instantiation declaration used to let callers assume both
outer and nested classes instantiations were defined in a different translation
unit.
If the instantiation