This revision was automatically updated to reflect the committed changes.
Closed by commit rL359744: [COFF, ARM64] Align global symbol by size for ARM64
MSVC ABI (authored by TomTan, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61225/new/
https://reviews.llvm.org/D61225
___
TomTan updated this revision to Diff 197208.
TomTan added a comment.
Herald added a subscriber: jholewinski.
Added test cases and also merged this alignment adjustment to
`getMinGlobalAlign` in `MicrosoftARM64TargetInfo`.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
riccibruno added a comment.
Since this is target-specific, is it right to put this here ?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61225/new/
https://reviews.llvm.org/D61225
___
cfe-commits mailing list
efriedma added subscribers: mgrang, rsmith.
efriedma added a comment.
I was going to ask if local variables are also supposed to be aligned this
way... but I guess there's no way for standard C++ code to tell without
explicitly making weird alignment assumptions, so let's not worry about that.
TomTan created this revision.
TomTan added a reviewer: efriedma.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Herald added a project: clang.
According to alignment section in below ARM64 ABI document, MSVC could increase
alignment of global data based on its total size.
