[PATCH] D61506: [OpenCL] Switch to C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL360330: [OpenCL] Switched CXX mode to be derived from C++17 (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61506: [OpenCL] Switch to C++17

kpet accepted this revision. kpet added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 ___ cfe-commits mailing list

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia updated this revision to Diff 198627. Anastasia added a comment. Added `HexFloat`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 Files: include/clang/Frontend/LangStandards.def test/CodeGenOpenCLCXX/addrspace-of-this.cl Index:

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia added a comment. In D61506#1493953 , @keryell wrote: > In D61506#1490555 , @rsmith wrote: > > > Per the OpenCL C++ 1.0 specification, section 2: > > > > > The OpenCL C++ programming language is based on

[PATCH] D61506: [OpenCL] Switch to C++17

keryell added a comment. In D61506#1490555 , @rsmith wrote: > Per the OpenCL C++ 1.0 specification, section 2: > > > The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 > > N 3690 language specification (a.k.a. C++14

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia marked an inline comment as done. Anastasia added a comment. In D61506#1490555 , @rsmith wrote: > Per the OpenCL C++ 1.0 specification, section 2: > > > The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 > > N 3690

[PATCH] D61506: [OpenCL] Switch to C++17

rsmith added a comment. Per the OpenCL C++ 1.0 specification, section 2: > The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 N > 3690 language specification (a.k.a. C++14 specification). I think it would be reasonable to permit changing the base C++ standard in OpenCL

[PATCH] D61506: [OpenCL] Switch to C++17

keryell added inline comments. Comment at: include/clang/Frontend/LangStandards.def:162 OpenCL, "OpenCL C++ 1.0", - LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | Digraphs | OpenCL) + LineComment | CPlusPlus | CPlusPlus11 |

[PATCH] D61506: [OpenCL] Switch to C++17

kpet added inline comments. Comment at: include/clang/Frontend/LangStandards.def:162 OpenCL, "OpenCL C++ 1.0", - LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | Digraphs | OpenCL) + LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia created this revision. Anastasia added a reviewer: kpet. Herald added subscribers: ebevhan, yaxunl. Caused test update as frontend now produces better IR due to copy elision. https://reviews.llvm.org/D61506 Files: include/clang/Frontend/LangStandards.def