aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61566/new/
https://reviews.llvm.org/D61566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dyatkovskiy updated this revision to Diff 198771.
dyatkovskiy added a comment.
Patch updates per review remarks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61566/new/
https://reviews.llvm.org/D61566
Files:
clang/lib/AST/DeclPrinter.cpp
clang/test/AST/ast-print-record-decl.c
aaron.ballman added inline comments.
Comment at: clang/lib/AST/DeclPrinter.cpp:958
+
+if (auto *Q = D->getQualifier())
+ Q->print(Out, Policy);
Don't use `auto` here as the type is not explicitly spelled out in the
initialization. If possible,
jdenny added reviewers: rsmith, aaron.ballman.
jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.
LGTM except for nits in the tests. I'm not close to C++ support in Clang, so
please give other reviewers a few days to comment just in case.
dyatkovskiy added a comment.
@jdenny ? @sepavloff ?
ping
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61566/new/
https://reviews.llvm.org/D61566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dyatkovskiy created this revision.
dyatkovskiy added a project: clang.
Herald added a subscriber: cfe-commits.
This fix adds out of scope member classes definitions support for AST Printer.
Repository:
rC Clang
https://reviews.llvm.org/D61566
Files:
clang/lib/AST/DeclPrinter.cpp
