[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai added a comment. In D61621#1497027 , @rnk wrote: > lgtm, thanks! > > In D61621#1496978 , @vsapsai wrote: > > > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > > Don't know if

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! In D61621#1496978 , @vsapsai wrote: > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > Don't know if it is

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai updated this revision to Diff 198875. vsapsai added a comment. - Improve `-fno-gnu-inline-asm` support for MS-compatibility too. Didn't use `-fms-compatibility` in the test and it seems to be working fine. Don't know if it is accidental and if I should add the flag. CHANGES SINCE LAST

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

rnk added a comment. I see one more instance of unprotected __asm__ usage, but it's under `#ifdef _MSC_VER`, it's the HLE extensions. Can you protect that, and then add another RUN line with a windows triple and -fms-extensions to test it? CHANGES SINCE LAST ACTION

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai created this revision. vsapsai added reviewers: craig.topper, GBuella. Herald added subscribers: dexonsmith, jkorous. vsapsai added a parent revision: D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.. Currently `immintrin.h` includes `pconfigintrin.h` and