[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

2019-05-08 Thread Owen Pan via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360256: [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones (authored by owenpan, committed by ). Herald

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

2019-05-07 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. This patch fixes `clang`. I copied the code from here to `clang/tools/clang-format/ClangFormat.cpp` in D61559 to fix `clang-format`. I'm not sure if the code here should be moved into a function, though. Repository: rC Clang

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

2019-05-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This looks good, but did you intend to make a new diff? It looks like D61559 didn't land yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61628/new/ https://reviews.llvm.org/D61628

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

2019-05-07 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added a reviewer: sammccall. owenpan added a project: clang. Herald added a subscriber: cfe-commits. Also fix a typo for the SCSU byte order mark. Repository: rC Clang https://reviews.llvm.org/D61628 Files: clang/lib/Basic/SourceManager.cpp Index: