[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Thanks for the review, Alex. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361779: [Preprocessor] Fix crash emitting note with framework location for file not… (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai updated this revision to Diff 200864. vsapsai added a comment. - Address review comments: don't introduce `HasBeenMapped` and rely on `CacheLookup.MappedName`. Changes are rebased, so diff between diffs can be noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:821 CurDir = nullptr; + bool HasBeenMapped = false; arphaman wrote: > NIT: It looks like `HasBeenMapped` should be always set when >

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

arphaman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:821 CurDir = nullptr; + bool HasBeenMapped = false; NIT: It looks like `HasBeenMapped` should be always set when `CacheLookup.MappedName` is set as well. Would it make sense to

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai created this revision. vsapsai added reviewers: arphaman, erik.pilkington, jkorous. Herald added a subscriber: dexonsmith. A filename can be remapped with a header map to point to a framework header and we can find the corresponding framework without the header. But if the original