[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

2019-05-14 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. leonardchan marked 2 inline comments as done. Closed by commit rC360707: [NewPM] Port HWASan and Kernel HWASan (authored by leonardchan, committed by ). Changed prior to commit:

[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

2019-05-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:179 - bool runOnFunction(Function ) override; - bool doInitialization(Module ) override; + bool instrumentFunction(Function ); + void initializeWithModule(Module );

[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

2019-05-10 Thread Philip Pfaffe via Phabricator via cfe-commits
philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. Nit aside, looks good! Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:179 - bool runOnFunction(Function ) override; - bool

[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

2019-05-09 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 198889. leonardchan marked 2 inline comments as done. leonardchan retitled this revision from "[NewPM] Port HWASan" to "[NewPM] Port HWASan and Kernel HWASan". leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D61709: [NewPM] Port HWASan

2019-05-09 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:956 + + if (LangOpts.Sanitize.has(SanitizerKind::HWAddress)) { +bool Recover = CodeGenOpts.SanitizeRecover.has(SanitizerKind::HWAddress); Can you also add `KernelHWAddress` (akin to

[PATCH] D61709: [NewPM] Port HWASan

2019-05-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: philip.pfaffe, fedor.sergeev, chandlerc, phosek. leonardchan added projects: LLVM, clang. Herald added subscribers: hiraditya, srhines. Port hardware assisted address sanitizer to new PM following the same guidelines as msan and