[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL361113: [clangd] Respect WarningsAsErrors configuration for clang-tidy (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks for the changes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge edited reviewers, added: sammccall; removed: ilya-biryukov. nridge added a subscriber: sammccall. nridge added a comment. Herald added a subscriber: ilya-biryukov. Changing reviewer to @sammccall as the updates to the patch are closely related to the discussion in D60953

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge updated this revision to Diff 199956. nridge added a comment. Update as per changes to dependent patch D60953 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346 + std::string CheckName = CTContext->getCheckName(Info.getID()); + if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) { +Level = DiagnosticsEngine::Error;

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge updated this revision to Diff 199552. nridge marked 2 inline comments as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841 Files:

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346 + std::string CheckName = CTContext->getCheckName(Info.getID()); + if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) { +Level =

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This completes the fix for https://bugs.llvm.org/show_bug.cgi?id=41218. Repository: rG LLVM Github Monorepo