[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

davezarzycki added a comment. Fixed: r361399 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.llvm.org/D62174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

davezarzycki added a comment. This breaks non-PIC builds. Was this planned or expected? Can we revert this until a fix is found? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.llvm.org/D62174

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rC361340: [Analysis] Link library dependencies to Analysis plugins (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62174?vs=200405=200615#toc Repository: rC

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek added a comment. This is an alternative to D62154 . With just the change to `HandleLLVMOptions.cmake`, we're seeing errors in Analysis plugins due to undefined symbols: error: 'error' diagnostics seen but not expected: (frontend): unable to load

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek created this revision. phosek added reviewers: hintonda, vitalybuka, Szelethus. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Repository: rC Clang