[PATCH] D62459: [clangd] Serialization support for RelationSlab

This revision was automatically updated to reflect the committed changes. nridge marked 4 inline comments as done. Closed by commit rL362353: [clangd] Serialization support for RelationSlab (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D62459: [clangd] Serialization support for RelationSlab

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG, thanks for the patch! Comment at: clang-tools-extra/clangd/index/Serialization.cpp:34 + switch (Role) { + case index::SymbolRole::RelationBaseOf: { +return

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected symbolRoleToRelationKind(index::SymbolRole);

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge updated this revision to Diff 202370. nridge marked 8 inline comments as done. nridge added a comment. Addressed most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62459/new/ https://reviews.llvm.org/D62459 Files:

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected

[PATCH] D62459: [clangd] Serialization support for RelationSlab

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:29 + +llvm::Expected symbolRoleToRelationKind(index::SymbolRole Role) { + // SymbolRole is used to record relations in the index. no need for errors, use

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This builds on D59407 to provide YAML and RIFF serialization support. Repository: