[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: +

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/docs/UsersManual.rst:1309 + + * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled. + * ``strict`` Enables precise and except, and disables

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + rjmccall wrote: > mibintc wrote: > > rjmccall

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + mibintc wrote: > rjmccall wrote: > > Combined how?

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 217426. mibintc added a comment. I made a couple changes to the UserManual in response to @rjmccall review Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + rjmccall

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1299 +.. option:: -fp-model=[values] + This should be something like `-fp-model=`. Square brackets mean optional elements in these docs. Comment at:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. ping, looking for a code review, especially from front end folks. thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added a comment. I don't believe I have any further comments. What do the front-end guys say? Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; andrew.w.kaylor wrote: >

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; mibintc wrote: > mibintc wrote: > > kpn wrote: > > > Wait, so "fast" and "precise" are the

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215666. mibintc marked an inline comment as not done. mibintc edited the summary of this revision. mibintc added a comment. I addressed some comments from @kpn: I corrected the documentation formatting and added some details, and used Diag instead of

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as not done. mibintc added a comment. I added an inline reply and unmarked some things that had been inadvertently marked done. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; kpn wrote: > Wait, so "fast" and "precise" are the same

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added inline comments. Comment at: clang/docs/UsersManual.rst:1307 + + ``precise `` Disables optimizations that are not value-safe on + floating-point data, although FP contraction (FMA) is enabled. Extra spaces? Comment at:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215225. mibintc added a comment. I added documentation for the new floating point options into clang/docs Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. Here's a summary of how the rm and eb options are set if user requests fp-model=strict, then the ConstrainedIntrinsic will be built with ( rmDynamic, ebStrict ) if user requests fp-model=except or fp-model=noexcept then the ConstrainedIntrinsic will be built with eb

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1623114 , @mibintc wrote: > @andrew.w.kaylor Thanks Andy. Reminder -- in a private document you > indicated to me that -fp-speculation=safe corresponds to the maytrap setting > for the exception argument.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1620174 , @andrew.w.kaylor wrote: > I'm not entirely caught up on this review. I've only read the most recent > comments, but I think I've got enough context to comment on the metadata > arguments. > > Based only on

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added a comment. I'm not entirely caught up on this review. I've only read the most recent comments, but I think I've got enough context to comment on the metadata arguments. Based only on the fp-model command line options, the front end should only ever use "round.dynamic"

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1619908 , @lebedev.ri wrote: > In D62731#1619892 , @mibintc wrote: > > > Compared to the 2nd revision, this patch moves all the changes into clang, > > removing the FPState file.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1603030 , @kpn wrote: > I actually don't have much of an opinion on what the command line argument > form should be. It may be helpful for it to be the same as one of the > commonly deployed compilers. The worst I

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > > > I think it would be convenient to have an "unset" setting for the different > > constrained modes, otherwise you

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

lebedev.ri added a comment. In D62731#1619892 , @mibintc wrote: > Compared to the 2nd revision, this patch moves all the changes into clang, > removing the FPState file. > > In the summary, I've copied information from Microsoft about the fp-model >

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 214003. mibintc edited the summary of this revision. mibintc added a comment. Compared to the 2nd revision, this patch moves all the changes into clang, removing the FPState file. In the summary, I've copied information from Microsoft about the fp-model

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added a comment. I actually don't have much of an opinion on what the command line argument form should be. It may be helpful for it to be the same as one of the commonly deployed compilers. The worst I think would be pretty close but with subtle differences. So if it can be made to work

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added a comment. Thanks for your review >>! In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > >> I think it would be convenient to have an

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

arsenm added inline comments. Comment at: llvm/include/llvm/IR/FPState.h:1 +#ifndef LLVM_FPSTATE_H +#define LLVM_FPSTATE_H Missing license header and c++ mode comment Comment at: llvm/lib/IR/FPState.cpp:1 +#include "llvm/IR/FPState.h"

RE: [PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

.com > Subject: [PATCH] D62731: [RFC] Add support for options -fp-model= and -fp- > speculation= : specify floating point behavior > > kpn added a comment. > > In D62731#1601310 <https://reviews.llvm.org/D62731#1601310>, @mibintc > wrote: > > > I think i

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added a comment. In D62731#1601310 , @mibintc wrote: > I think it would be convenient to have an "unset" setting for the different > constrained modes, otherwise you need a boolean that says "no value was > provided for this option". But i'm a

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 211770. mibintc added a comment. Herald added subscribers: hiraditya, mgorny. The IRBuilder now has been taught about constrained fadd and friends. I simply updated my patches to work with the committed revision. Note that this diff now contains what was

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

lebedev.ri added a comment. Documentation missing. All the blurb from patch description should be in `doc/` Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc created this revision. mibintc added a reviewer: chandlerc. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Intel would like to contribute a patch to implement support for these Intel- and Microsoft -fp options. This message is to describe the options and request